swiftui-code-review-checklist

SwiftUI Code Review Checklist

Comprehensive checklist for SwiftUI PR reviews.

Directory structure

swiftui-code-review-checklist/
├── SKILL.md (このファイル)
└── references/
    └── code-review-checklist.md

Reference files

references/code-review-checklist.md

Code review checklist (by priority):

🔴 Critical (Required)

• State management: SSOT violations, inappropriate Property Wrappers
• Performance: unnecessary re-renders, memory leaks
• Security: exposure of sensitive information

🟡 Important

• Component design: separation of responsibilities, reusability
• Data flow: Binding, use of environment values
• Asynchronous processing: Task management, error handling

🟢 Nice to Have (Recommended)

• UI/UX: animations, layout
• Accessibility: VoiceOver, Dynamic Type
• Testing: previews, unit tests

Usage

During PR review

1. references/code-review-checklist.mdopen
2. Check in priority order (🔴→🟡→🟢)
3. If there are issues, present specific improvement suggestions

During self-review

1. Check the checklist before creating a PR
2. Verify your own code

Quick check items

State management

• Is @State used appropriately?
• Is there any duplicated state?
• Is the Binding direction correct?

Performance

• Are unnecessary re-renders occurring?
• Is LazyStack/Grid used appropriately?
• Is heavy processing executed in the background?

Component design

• Is the View's responsibility single?
• Is the design reusable?
• Is the order of modifiers correct?

Related skills

• swiftui-coding-guidelines: best practices and anti-patterns
• swiftui-ssot: details of state management
• swiftui-accessibility: accessibility check