Phase 2 - Deep Analysis:
- Algorithm correctness
- Edge case handling
- Error handling completeness
- Resource management
Phase 3 - Context Evaluation:
- Breaking changes to public APIs
- Side effects on existing functionality
- Dependency compatibility
Phase 4 - Standards Compliance:
- Naming conventions
- Documentation requirements
- Test coverage
</example>
Security:
- Input validation
- Authentication/authorization
- Data sanitization
- Secrets handling
Performance:
- Algorithm efficiency
- Resource usage
- Memory leaks
- N+1 queries
Maintainability:
- Clear naming
- Appropriate comments
- Single responsibility
- DRY principle
Testability:
- Test coverage adequate
- Tests meaningful
- Edge cases tested
</example>
Important: Should fix before merge
- Logic errors
- Missing error handling
- Performance issues
Suggestion: Nice to have improvements
- Code style
- Refactoring opportunities
- Documentation
Positive: What was done well
- Good patterns
- Clever solutions
- Thorough testing
</example>
<best_practices> Analyze task dependencies before execution to determine parallel vs sequential execution model Provide comprehensive context to sub-agents including file paths, tool usage, and reference implementations Systematically review all phases: initial scan, deep analysis, context evaluation, standards compliance Balance critical feedback with positive observations of good practices Provide file:line references and concrete improvement suggestions Check Serena memories for existing patterns before delegating implementation tasks </best_practices>
<anti_patterns> Focusing on code style issues when functionality is broken Address critical and important issues first, style suggestions last Approving changes without thorough review Systematically review all phases: scan, deep analysis, context, standards Providing only critical feedback without acknowledging good work Balance feedback with positive observations of good practices Giving feedback without specific, actionable suggestions Provide file:line references and concrete improvement suggestions Executing independent tasks sequentially Identify and execute independent tasks in parallel for efficiency Attempting to parallelize tasks with data dependencies Analyze dependencies and execute dependent tasks sequentially </anti_patterns>
<error_escalation inherits="core-patterns#error_escalation"> Sub-agent returns partial results Sub-agent task fails Critical task cannot be completed Sub-agent introduces breaking change </error_escalation>
<related_skills> Use for memory checks and symbol operations during delegation Use when code review reveals unclear implementation details Use to verify test coverage and quality during review </related_skills>
<related_agents> Execute delegated tasks following this skill's orchestration patterns Review implementation outputs for quality compliance Cross-validate task results before integration </related_agents>