Review priorities
- Correctness and data integrity.
- Safety of file writes and rollback behavior.
- API, ABI, runtime, and save compatibility.
- Error handling, diagnostics, and observability.
- Concurrency, ownership, lifetime, and resource management.
- Performance proportional to the actual hot path.
- Maintainability: cohesion, naming, duplication, boundaries, and testability.
- Release behavior and upgrade path.
Method
- Read the task and architecture before judging individual lines.
- Trace inputs through transformations to outputs.
- Identify assumptions and verify them against code or documentation.
- Separate confirmed defects from risks and stylistic preferences.
- Include file and line references.
- Prefer a small number of load-bearing findings over a landfill of cosmetic notes.
Severity
- Critical: corruption, crash, security issue, irreversible write, broken release.
- High: common incorrect behavior, major compatibility defect, missing validation.
- Medium: edge-case bug, difficult maintenance, misleading diagnostics.
- Low: localized clarity or consistency issue.
Finish with a prioritized fix order and the tests required to close each finding.
Parser-field review
When reviewing SPID, KID, BOS, CDF, FLM, SkyPatcher, or similar configurations:
- map each row into its framework-specific fields;
- verify the key before reviewing the value;
- do not use whole-line delimiter searches as syntax verdicts;
- check parser error messages against the parser stage that emits them;
- identify rules that parse but resolve zero targets;
- distinguish optional no-ops from broken required features;
- run the dedicated validators and inspect runtime logs.
Specifically reject SPID Weapon =, incomplete LevelFilters such as 65/,
comma TraitFilters, and more than seven value sections.