SuperAPI AI Directory

coding-review-simplify

Coding & development

View repository

Updated 10-16 01:27

About this skill

Coding Review Simplify

Choose the branch before selecting a model. Coordinator work and deterministic commands proceed within invocation authority. Apply this method in the assigned implementer or reviewer context. The implementer performs authorized cleanup; an independent reviewer remains read only. This method does not dispatch a worker. For a worker dispatch, use shared/references/model-preview.md and its one approved route snapshot. Nested skills and runners consume it without another selection or worker.

Tighten a completed diff while the implementation context is fresh. The result is a smaller coherent shape, or a focused concern with proof. The next consumer is the approved review plan.

This is a behavior-preserving pass. It does not create a new review route. The approved routing plan decides whether a later focused, seam, or deep review is needed.

Workflow

  1. Read the task acceptance contract, changed files, diff, and verification already captured. Start with the changed surface and expand only across a real boundary.
  2. Check the change against its intended observable behavior. Report a concern only when it can cause a bug, regression, maintenance trap, data risk, weak verification, or material reader confusion.
  3. Simplify only when the result remains behavior-preserving. Keep validation at trust boundaries, authorization checks, invariant assertions, encoding, and accessibility safeguards unless evidence proves they are dead. Before deletion, check supported callers and entry points, including runtime loading. Require evidence that the deletion preserves side effects, failure behavior, and required safeguards, plus relevant verification. Unknown reachability or missing preservation evidence blocks deletion.
  4. Apply the matching review concern in the current role when the diff adds a helper, changes ownership, or affects a hot or asynchronous path. Read the matching persona from references/personas/ only for that concern. Apply data-systems-coding-lens when stored state or asynchronous behavior changes. Dispatch an independent specialist only for a material risk or unresolved question through an approved route.
  5. Run the Connascence Pass only when the diff crosses a boundary or feels tangled. Identify what is connascent, then state its strength, locality, degree, and smallest safe remedy. Leave local static coupling alone when extraction adds indirection without safety.
  6. Apply the relevant lens to a boundary-wide design concern in the current role. Do not start a broader refactor from this pass.
  7. Turn each accepted concern into a focused fix, test, check, or explicit follow-up. Re-run only the verification affected by a made change.

Simplification cues

Use the clean-code vocabulary. Look for a helper with no decision, a type that hides an awkward contract, needless memoization or effects, compatibility code with no callers, and unrelated diff churn. A name can be better than a wrapper. Duplication can stay when the concepts may diverge.

Output

For review-only work, list findings by severity with location, consequence, smallest useful fix, and verification.

For implementation work, return:

  1. Outcome: safe as is, simplified, needs a focused fix, or needs design escalation.
  2. Changes made.
  3. Verification captured.
  4. Remaining risk.

Use references/team-checklists.md only immediately before handoff or deployment. Do not measure success by lines removed; the measure is a simpler change that preserves observable behavior.