Review the actual behavior and cross-module impact of Paddle code. Priority, comment format, and posting strategy are decided by the caller; this skill only provides repository-level review rules.
Rule Loading
Before starting the review, read all Markdown files under .agents/skills/ai-review/references/ , which must include basic rules. Decide whether to apply other rules based on the applicable paths and trigger conditions declared by each file; do not skip loading merely because the changed paths differ.
When adding extension rules, use kebab-case file names under references/ and state the applicable paths, trigger conditions, and verifiable rule sources at the beginning of the file. Do not repeat the basic rules, comment format, or posting strategy.
Review Process
- Read the PR description and the full diff, and confirm the change goals, impact scope, compatibility commitments, and user-visible behavior.
- Use
rgto trace definitions, callers, registration entry points, configuration entry points, implementations, and tests; cross-module changes must check the contract on both ends. - Verify candidate issues against complete functions, adjacent implementations, and existing tests, and report only after confirming reproducibility or clear code evidence.
- Comments should point out the specific location, impact, trigger conditions, and direction for modification; do not report unfounded speculation, pure style preferences, or generalized suggestions.
- Choose the tests closest to the change based on risk, and separately record static checks, CPU verification, and incomplete verification that depends on GPU/multi-card/specific hardware.
More specific extension rules take precedence over basic rules; when rules conflict and cannot be resolved by code or repository conventions, confirm with the maintainers.
Applicable Existing Skills
When specialized domains are involved, also read the references of the corresponding skill and take the actual source code as authoritative: use paddle-op-devfor operator development, paddle-design-distributedfor distributed design, paddle-buildfor compilation, and paddle-debug、paddle-design-compiler、paddle-eager-graph or paddle-phi-kernel。
Basic Principles
- Correctness, security, and compatibility take precedence over format and naming.
- Distributed, operator, and numerical paths must check forward/backward, boundary conditions, and fallback paths at the same time.
- Behavior changes must have single-card, multi-card, or device coverage matched to the risk; tests that mock out the logic under test cannot replace real verification.
- Draw conclusions only based on source code, tests, documentation, and reproducible run results; when verification is impossible, clearly state the environment limitations.