This is the review rubric behind the /review pull-request command. The
reviewer receives the requested REVIEW DEPTH (mode=light|strict), then reads
this file.
It lives in skills/ so the rubric can be diffed, reviewed and evolved like
code instead of being buried in YAML, but it is deliberately inert: the
frontmatter carries disable-model-invocation: true, so Claude Code drops it
from the advertised skill list and refuses to auto-invoke it. Reading it by
path, which is exactly what the reviewer does, still works. Do not add a
when_to_use: field — that is the trigger text that would make it activate on
its own.
Pick the depth
Read only the reference for the depth the caller passed. Each one is a complete rubric, so loading the other adds nothing but noise:
REVIEW DEPTH |
Comment trigger | Read |
|---|---|---|
light |
/review |
skills/pr-review/references/light.md |
strict |
/review mode=strict |
skills/pr-review/references/strict.md |
Mandatory workflow — never skip or reorder
- Read the PR diff first:
gh pr diff $PR_NUMBER --repo $REPO. - From the changed files and areas, identify the relevant domain skills. Use
Glob on
skills/*/SKILL.mdto see what exists rather than assuming names — the set changes over time, and Megatron-LM domain guides carry anmcore-prefix (mcore-testing,mcore-cicd,mcore-build-and-dependency,mcore-linting-and-formatting,mcore-run-on-slurm,mcore-split-pr,mcore-onboard-gb200-1node-tests, …). - Read those
SKILL.mdfiles with the Read tool. - Read the depth reference from the table above.
- For Python changes, read the local style-guide.md with the Read tool. Do not load the entire Google Python Style Guide by default. Consult relevant sections as needed; read it in full when performing a comprehensive style audit.
- Only then review.
The order is what makes the review worth reading. A reviewer who forms an
opinion before loading mcore-testing will invent a test convention that this
repo does not use, and a confidently wrong review comment costs the author more
time than no review at all.
Posting findings
Use inline ```suggestion blocks only for simple, self-contained line
replacements — typos, renames, single-line fixes. For structural changes that
add, remove or reorganize blocks of code (a new function, an inserted YAML
step, reordered logic), post a top-level PR comment with a fenced code block
showing the proposed change instead. GitHub's suggestion blocks can only
replace the exact lines they are anchored to, so an insertion or a multi-block
restructuring applied via suggestion silently corrupts the author's file.
Findings that deeper analysis invalidates should be dropped entirely rather than hedged. A hedged comment transfers the work of disproving it to the author.
Completion — what to post at the end, and when to approve — is depth-specific and covered in the reference file.