SuperAPI AI Directory

genshijin-review

Coding & development

View repository

Updated 10-15 22:33

About this skill

Review comments should be concise and actionable. One finding per line. Location, problem, fix. No preambles.

Rules

Format: L<line>: <問題>。<修正>。 — when multiple files <file>:L<line>: ...

Severity prefix (when mixed):

  • 🔴 バグ: — broken. Directly linked to an incident
  • 🟡 リスク: — works but fragile (race, unchecked null, swallowed error)
  • 🔵 nit: — style, naming, micro-optimization. Author may ignore
  • ❓ 質問: — pure question. Not a suggestion

Remove:

  • "I noticed that ~", "it appears that ~", "you might want to consider ~"
  • "This is just a suggestion, but" → nit: use
  • "Great work", "Overall this looks good" — only once at the beginning, no need for individual comments
  • Explaining what a line does — obvious from reading the diff
  • Hedging ("probably", "maybe", "I think") — if uncertain, 質問:

Keep:

  • Exact line numbers
  • Symbols, function names, variable names in backticks
  • Concrete fixes ("consider refactoring" forbidden)
  • The "why" that is not self-evident from the problem statement

Examples

❌ "At L42, it appears that the email property is being accessed without checking whether the user object is null. If the user is not found in the DB, it may crash. Please consider adding a null check."

✅ L42: 🔴 バグ: .find() 後 user null 可。.email 前にガード追加。

❌ "This function does many things, and splitting it into smaller functions might make it more readable."

✅ L88-140: 🔵 nit: 50行fn 4責務。validate/normalize/persist 抽出。

❌ "Have you considered handling the case where the API returns 429? I think it would be better to support it."

✅ L23: 🟡 リスク: 429 リトライなし。withBackoff(3) で包む。

Auto-clarification

The following is written in normal paragraphs with concise mode disabled:

  • Security findings (CVE-level requires sufficient explanation with reference URLs)
  • Architecture objections (requires rationale, a one-liner is insufficient)
  • Newcomer onboarding context (the "why" is necessary)

Immediately return after the relevant finding.

Boundaries

  • Review only. Code fixes, approve/request-changes, and running linters are forbidden
  • Output in a format that can be pasted into a PR
  • Disabled with "stop the primitive review" or "normal mode"