SuperAPI AI Directory
Partner with us中文AI newsFavorites
Skillsreview

review

General & other

View repository

Updated 10-15 17:32

About this skill

Code Review

Review the current branch's changes against the base branch.

Usage

  • /review or /review 2 - Standard review
  • /review 1 - Quick sanity check
  • /review 3 - Deep analysis (core checks)
  • /review 4 - Experimental (Level 3 + advanced checks for evaluation)

Setup

Detect base branch

The base branch is NOT always main. Determine it in this order:

  1. Open PR — check if one exists and use its base: 
    gh pr view --json baseRefName -q '.baseRefName' 2>/dev/null
  2. Default branch — fall back to the repo default: 
    git rev-parse --abbrev-ref origin/HEAD 2>/dev/null | sed 's@^origin/@@'
  3. Last resort — main

Store the result as $base and use it for all diffs below.

# Get the diff
git diff $base...HEAD

# Get list of changed files
git diff --name-only $base...HEAD

Level 1: Quick

Fast sanity check. Only blockers.

  • Types compile (tsc --noEmit)
  • No obvious runtime errors
  • No secrets or credentials in diff
  • No console.log/debugger statements left in
  • Imports resolve

Output: "No blockers found" or list of blockers. No grade.

Level 2: Standard

Full review with grade.

Checklist

Logic & Correctness

  • Code does what the PR description says
  • Edge cases handled (null, empty, zero, negative)
  • Error paths handled appropriately

Types & Safety

  • No any types introduced
  • Null/undefined properly checked
  • Type assertions (as) justified

React Patterns

  • No useEffect for derived state (use useMemo or compute directly)
  • No useEffect for data fetching (use React Query/tRPC/server components)
  • Dependencies arrays correct
  • No missing keys in lists

API & Data

  • API returns only needed fields
  • No N+1 queries visible in diff
  • Mutations invalidate relevant caches

Security Basics

  • User input validated/sanitized
  • No SQL/command injection vectors
  • Auth checks present where needed

Ticket Alignment

  • Changes address the ticket's stated problem (not an adjacent issue)
  • Acceptance criteria from ticket are covered by the diff
  • No significant scope creep beyond ticket intent

Style

  • Follows existing patterns in codebase
  • No commented-out code
  • Clear naming

Issue Attribution

For each issue found, determine whether it was introduced by this branch or is pre-existing:

  1. Run git blame on the flagged lines
  2. If the commit predates git merge-base HEAD $base, it is pre-existing
  3. If introduced by a commit on this branch, it is introduced

Pre-existing issues still get reported but must not affect the grade. They are informational — the author can choose to fix in-branch, send to tech-debt, or dismiss.

Output Format

## Review: [PR/Branch name]

### Summary
[2-3 sentences on what this change does and overall impression]

### Issues
[List any problems found, grouped by severity. Only issues introduced by this branch.]

### Pre-existing Issues
[Problems found in code touched by this branch but not introduced by it. Does not affect grade.]

### Suggestions
[Optional improvements, not blockers]

### Grade: [A-F] ([score]/100)
[Grade reflects only issues introduced by this branch, not pre-existing ones.]

Level 3: Deep

Everything in Level 2, plus read and apply each check file in checks/ directory.

For each check file:

  1. Read the file from ~/.claude/skills/review/checks/
  2. Apply its rules to the diff
  3. Report findings under a heading matching the check name

Check files to load

Core (always applied)

  • security.md - Security audit
  • async.md - Async/await patterns
  • errors.md - Error handling coverage
  • concurrency.md - Race conditions
  • idempotency.md - Idempotent operations
  • timezones.md - Date/timezone handling
  • memory.md - Memory leaks
  • complexity.md - Cyclomatic/cognitive complexity (Semgrep-backed)
  • dead_code.md - Dead code detection (Semgrep-backed)
  • dependencies.md - Dependency vulnerabilities (Semgrep SCA + audit)
  • testing.md - Test coverage gaps (static analysis)
  • logic.md - Business logic correctness (intent vs implementation)
  • ticket_alignment.md - Ticket drift detection (branch vs implementation)

Shell/Infra (for .sh, .zsh, .yml files)

  • shell.md - Shell script quality
  • ansible.md - Ansible task quality
  • dotfiles.md - Dotfiles/config management

React/JS (for .ts, .tsx, .js, .jsx files)

  • nplus1.md - Database and API query patterns
  • accessibility.md - a11y compliance
  • hooks.md - React Rules of Hooks
  • antipatterns.md - React antipatterns
  • state.md - State mutation patterns
  • performance.md - Performance issues
  • boundaries.md - Error boundaries and fault tolerance

Output Format

Same as Level 2, but with additional sections for each check that found issues.

Level 4: Experimental

Everything in Level 3, plus experimental checks being evaluated for promotion to Level 3.

Run periodically to see if any of these should become standard checks.

Additional check files to load

  • ast.md - Duplicates, dependency graphs
  • framework.md - Next.js, tRPC, Prisma, RSC patterns
  • documentation.md - JSDoc, comments, README sync
  • git.md - Commit messages, large files, conflict markers

Output Format

Same as Level 3, but with additional sections for experimental checks. Note which experimental checks found useful issues - candidates for promotion to Level 3.

Promoting Checks

If an experimental check consistently finds real issues, promote it to Level 3:

  1. Move the check file entry from Level 4 list to Level 3 list
  2. Update this file